maqingxiang commented on a change in pull request #7083:
[hotfix][flink-runtime] modify maxAttempts when find a unique file name for the
spilling channel
URL: https://github.com/apache/flink/pull/7083#discussion_r232977700
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
##########
@@ -630,8 +630,7 @@ private FileChannel createSpillingChannel() throws
IOException {
}
// try to find a unique file name for the spilling
channel
- int maxAttempts = 10;
- for (int attempt = 0; attempt < maxAttempts; attempt++)
{
+ for (int attempt = 0; attempt < tempDirs.length;
attempt++) {
Review comment:
I think this check is mainly used to check the existence of the mount disk,
and `tempDirs.length` is the number of disks that are mounted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
