azagrebin commented on a change in pull request #7077: [FLINK-10736][E2E tests] 
Use already uploaded to s3 file in shaded s3 e2e tests
URL: https://github.com/apache/flink/pull/7077#discussion_r233394753
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_shaded_presto_s3.sh
 ##########
 @@ -22,15 +22,11 @@
 source "$(dirname "$0")"/common.sh
 source "$(dirname "$0")"/common_s3.sh
 
-s3_put $TEST_INFRA_DIR/test-data/words $ARTIFACTS_AWS_BUCKET 
flink-end-to-end-test-shaded-presto-s3
 
 Review comment:
   I think this is good point. We can just remove trap with deletion of the 
file atm. It should address the eventual consistency problem and then we will 
rethink the concept of static s3 content. I pushed a commit for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to