[
https://issues.apache.org/jira/browse/FLINK-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687830#comment-16687830
]
ASF GitHub Bot commented on FLINK-10877:
----------------------------------------
zentol commented on a change in pull request #7094: [FLINK-10877] Cleanup
flink-connector-kafka pom file
URL: https://github.com/apache/flink/pull/7094#discussion_r233797407
##########
File path: flink-connectors/flink-connector-kafka/pom.xml
##########
@@ -140,28 +140,6 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-kafka-base_${scala.binary.version}</artifactId>
<version>${project.version}</version>
- <exclusions>
- <!-- exclude Kafka dependencies -->
- <exclusion>
- <groupId>org.apache.kafka</groupId>
-
<artifactId>kafka_${scala.binary.version}</artifactId>
Review comment:
yes, since they are still available during tests which dependency
convergence covers as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove duplicate dependency entries in kafka connector pom
> ----------------------------------------------------------
>
> Key: FLINK-10877
> URL: https://issues.apache.org/jira/browse/FLINK-10877
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Trivial
> Labels: pull-request-available
>
> The {{flink-connectorkafka}} {{pom.xml}} contains multiple dependency entries
> for {{flink-connector-kafka-base}} and moreover excludes dependencies from a
> test-jar. This is not necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
