[ 
https://issues.apache.org/jira/browse/FLINK-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688083#comment-16688083
 ] 

ASF GitHub Bot commented on FLINK-10899:
----------------------------------------

tillrohrmann closed pull request #7104: [FLINK-10899] Remove explicit version 
tag from flink-metrics-availability-test and 
flink-metrics-reporter-prometheus-test
URL: https://github.com/apache/flink/pull/7104
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-end-to-end-tests/flink-metrics-availability-test/pom.xml 
b/flink-end-to-end-tests/flink-metrics-availability-test/pom.xml
index eea4ef8458d..a6e5f00e38c 100644
--- a/flink-end-to-end-tests/flink-metrics-availability-test/pom.xml
+++ b/flink-end-to-end-tests/flink-metrics-availability-test/pom.xml
@@ -23,12 +23,12 @@ under the License.
                <artifactId>flink-end-to-end-tests</artifactId>
                <groupId>org.apache.flink</groupId>
                <version>1.8-SNAPSHOT</version>
+               <relativePath>..</relativePath>
        </parent>
 
        <modelVersion>4.0.0</modelVersion>
 
        <artifactId>flink-metrics-availability-test</artifactId>
-       <version>1.8-SNAPSHOT</version>
 
        <dependencies>
                <dependency>
diff --git 
a/flink-end-to-end-tests/flink-metrics-reporter-prometheus-test/pom.xml 
b/flink-end-to-end-tests/flink-metrics-reporter-prometheus-test/pom.xml
index cb5d83e3ff8..c6fe838c084 100644
--- a/flink-end-to-end-tests/flink-metrics-reporter-prometheus-test/pom.xml
+++ b/flink-end-to-end-tests/flink-metrics-reporter-prometheus-test/pom.xml
@@ -23,12 +23,12 @@ under the License.
                <artifactId>flink-end-to-end-tests</artifactId>
                <groupId>org.apache.flink</groupId>
                <version>1.8-SNAPSHOT</version>
+               <relativePath>..</relativePath>
        </parent>
 
        <modelVersion>4.0.0</modelVersion>
 
        <artifactId>flink-metrics-reporter-prometheus-test</artifactId>
-       <version>1.8-SNAPSHOT</version>
 
        <dependencies>
                <dependency>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Don't explicitly set version in flink-end-to-end-tests sub modules
> ------------------------------------------------------------------
>
>                 Key: FLINK-10899
>                 URL: https://issues.apache.org/jira/browse/FLINK-10899
>             Project: Flink
>          Issue Type: Bug
>          Components: E2E Tests
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: pull-request-available
>
> The submodules {{flink-end-to-end-tests/flink-metrics-availability-test}} and 
> {{flink-end-to-end-tests/flink-metrics-reporter-prometheus-test}} set 
> explicitly a pom version. This is not needed and can be removed. 
> Additionally, we could specify the parent pom directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to