jgrier commented on a change in pull request #7099: [FLINK-10887] [jobmaster] Add source watermark tracking to the JobMaster URL: https://github.com/apache/flink/pull/7099#discussion_r233862737
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/watermark/SourceWatermark.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.watermark; + +import java.io.Serializable; + +/** + * This represents the watermark for a single source partition. + */ +public class SourceWatermark implements Serializable { Review comment: Yeah, my intention was to keep this very focused on the exact use case at hand -- to provide simple state sharing for watermarks in the service of the source synchronization effort. This is why the very specific naming and lack of additional features like namespaces, etc. If we were to generalize this more it would be good to understand some other specific use cases -- and also to consider whether it's important to tackle that here or just go with the simplest interface we need for the task at hand. @tweise @aljoscha If we do something more general what are you thinking? Something more like a hash table or a collection of namespaced hashtables? Would we need to make the key and value types generic, etc? Would we want to then distribute the entire hashtable to every sub-task? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
