[
https://issues.apache.org/jira/browse/FLINK-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Knauf updated FLINK-10905:
-------------------------------------
Description:
If you set S3 credentials {{via s3.access-key}} and {{s3.secret-key}} the
credentials are logged on DEBUG level in {{HadoopConfigLoader}}:104.
{quote}job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
- Adding Flink config entry for s3.secret-key as presto.s3.secret-key=minio123
to Hadoop config
job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
- Adding Flink config entry for s3.endpoint as
presto.s3.endpoint=[http://172.17.0.1:9001|http://172.17.0.1:9001/] to Hadoop
config
job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
- Adding Flink config entry for s3.access-key as presto.s3.access-key=minio to
Hadoop config
{quote}
To be consistent we should hide these as in {{GlobalConfiguration}}.
was:
If you set S3 credentials {{via s3.access-key}} and {{s3.secret-key}} the
credentials are logged on DEBUG level in HadoopConfigLoader:104.
{quote}
job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
- Adding Flink config entry for s3.secret-key as
presto.s3.secret-key=minio123 to Hadoop config
job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
- Adding Flink config entry for s3.endpoint as
presto.s3.endpoint=http://172.17.0.1:9001 to Hadoop config
job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
- Adding Flink config entry for s3.access-key as presto.s3.access-key=minio
to Hadoop config
{quote}
> HadoopConfigLoader logs Credentials on DEBUG level
> --------------------------------------------------
>
> Key: FLINK-10905
> URL: https://issues.apache.org/jira/browse/FLINK-10905
> Project: Flink
> Issue Type: Improvement
> Components: FileSystem
> Reporter: Konstantin Knauf
> Priority: Critical
>
> If you set S3 credentials {{via s3.access-key}} and {{s3.secret-key}} the
> credentials are logged on DEBUG level in {{HadoopConfigLoader}}:104.
> {quote}job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
> org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
> - Adding Flink config entry for s3.secret-key as
> presto.s3.secret-key=minio123 to Hadoop config
> job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
> org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
> - Adding Flink config entry for s3.endpoint as
> presto.s3.endpoint=[http://172.17.0.1:9001|http://172.17.0.1:9001/] to Hadoop
> config
> job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG
> org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader
> - Adding Flink config entry for s3.access-key as presto.s3.access-key=minio
> to Hadoop config
> {quote}
> To be consistent we should hide these as in {{GlobalConfiguration}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
