azagrebin opened a new pull request #7118: [FLINK-10482] Fix double counting of checkpoint stat URL: https://github.com/apache/flink/pull/7118 ## What is the purpose of the change This PR fixes double counting of checkpoints in progress in their statistics. ## Brief change log - If savepoint fails, restart checkpoint coordinator only if job is still running (prevents from double stop of checkpoint coordinator in case of global failure) - clear pending checkpoint in checkpoint coordinator stop method before aborting them (prevents from double aborting them if stop is called inside abort) - log error if number of checkpoints in progress is negative but do not throw exception and do not fail the job (prevents stats bugs from failing the job) ## Verifying this change submit DataStreamAllroundTestProgram in a loop in aws emr, wait for failure, check there was no negative number of checkpoints logs ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
