zentol commented on a change in pull request #7098: [FLINK-10869] [build]
Update S3 tests to reference new access key environment variables.
URL: https://github.com/apache/flink/pull/7098#discussion_r234231999
##########
File path: flink-end-to-end-tests/test-scripts/common_s3.sh
##########
@@ -68,8 +68,8 @@ function s3_setup {
trap s3_cleanup EXIT
cp $FLINK_DIR/opt/flink-s3-fs-hadoop-*.jar $FLINK_DIR/lib/
- echo "s3.access-key: $ARTIFACTS_AWS_ACCESS_KEY" >>
"$FLINK_DIR/conf/flink-conf.yaml"
Review comment:
let's either change these to use the variables defined at the top
(`AWS_REGION`, `AWS_ACCESS_KEY`, `AWS_SECRET_KEY`), or remove said variables
since they are unused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
