pnowojski commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible URL: https://github.com/apache/flink/pull/7087#discussion_r234237406
########## File path: flink-end-to-end-tests/test-scripts/test_sql_client_kafka010.sh ########## @@ -19,4 +19,4 @@ set -Eeuo pipefail -source "$(dirname "$0")"/test_sql_client_kafka_common.sh 0.10 0.10.2.0 3.2.0 3.2 "kafka-0.10" +source "$(dirname "$0")"/test_sql_client_kafka_common.sh 0.10 0.10.2.0 3.2.0 3.2 "kafka-0.10" "0.10" Review comment: This starts getting ridiculous: - `0.10` - `0.10.2.0` - `"0.10"` - `"kafka-0.10"` or - `3.2` - `3.2.0` 🙄 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
