[
https://issues.apache.org/jira/browse/FLINK-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689528#comment-16689528
]
ASF GitHub Bot commented on FLINK-10869:
----------------------------------------
StephanEwen commented on a change in pull request #7098: [FLINK-10869] [build]
Update S3 tests to reference new access key environment variables.
URL: https://github.com/apache/flink/pull/7098#discussion_r234236294
##########
File path:
flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3RecoverableWriterTest.java
##########
@@ -87,7 +79,8 @@ public static void cleanUp() throws IOException {
@Test(expected = UnsupportedOperationException.class)
public void requestingRecoverableWriterShouldThroughException() throws
Exception {
- FlinkS3FileSystem fileSystem = (FlinkS3FileSystem)
FileSystem.get(basePath.toUri());
+ URI s3Uri = URI.create(S3TestCredentials.getTestBucketUri());
Review comment:
It never used the `TEST_DATA_DIR` - the `getFileSystem()` only uses scheme
and authority, path does not matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update S3 testing settings
> --------------------------
>
> Key: FLINK-10869
> URL: https://issues.apache.org/jira/browse/FLINK-10869
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Priority: Major
> Labels: pull-request-available
>
> Currently S3 tests go against a bucket hosted by 'data Artisans'.
> As part of reworking the AWS permission setup, we need to adapt the
> credentials and buckets for these tests.
> Future tests should refer to the following environment variables for S3 tests:
> * `IT_CASE_S3_BUCKET`
> * `IT_CASE_S3_ACCESS_KEY=AKIAIQKDG4KW5QA6TFGA`
> * `IT_CASE_S3_SECRET_KEY`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
