[
https://issues.apache.org/jira/browse/FLINK-10880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689670#comment-16689670
]
ASF GitHub Bot commented on FLINK-10880:
----------------------------------------
zentol commented on a change in pull request #7129: [FLINK-10880] Exclude
JobManagerOptions#EXECUTION_FAILOVER_STRATEGY from documentation
URL: https://github.com/apache/flink/pull/7129#discussion_r234280027
##########
File path:
flink-docs/src/main/java/org/apache/flink/docs/configuration/ConfigOptionsDocGenerator.java
##########
@@ -213,6 +213,12 @@ static void processConfigOptions(String rootDir, String
module, String packageNa
}
}
+ private static boolean isValidConfigOption(Field field) {
Review comment:
I'm not fond of the naming as a deprecated options is still valid.
Maybe split this into `isConfigOption` that does the `ConfigOption` check
and `shouldBeDocumented` that does the deprecation/exclusion checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Failover strategies should not be applied to Batch Execution
> ------------------------------------------------------------
>
> Key: FLINK-10880
> URL: https://issues.apache.org/jira/browse/FLINK-10880
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.6.2
> Reporter: Stephan Ewen
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.6.3, 1.7.0
>
>
> When configuring a failover strategy other than "full", DataSet/Batch
> execution is currently not correct.
> This is expected, the failover region strategy is an experimental WIP feature
> for streaming that has not been extended to the DataSet API.
> We need to document this and prevent execution of DataSet features with other
> failover strategies than "full".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
