[ 
https://issues.apache.org/jira/browse/FLINK-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691650#comment-16691650
 ] 

ASF GitHub Bot commented on FLINK-10791:
----------------------------------------

yanghua edited a comment on issue #7038: [FLINK-10791] Provide end-to-end test 
for Kafka 0.11 connector
URL: https://github.com/apache/flink/pull/7038#issuecomment-439877741
 
 
   I think @tillrohrmann  means that we don't want the e2e test to rely on 
`flink-dist`. This way we can run `flink-end-to-end-tests` directly without 
packaging the entire project.
   
   But @pnowojski  's considerations are also correct. If we still need to 
provide an example of the Kafka connector in `flink-examples`, it will cause 
some code duplication.
   
   I personally feel that temporary code duplication is acceptable. Over time, 
e2e's code may change and evolve independently (to test more features), while 
the Kafka connector only provides a simple usage example. 
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide end-to-end test for Kafka 0.11 connector
> ------------------------------------------------
>
>                 Key: FLINK-10791
>                 URL: https://issues.apache.org/jira/browse/FLINK-10791
>             Project: Flink
>          Issue Type: Test
>          Components: E2E Tests
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to