NicoK commented on a change in pull request #6705: [FLINK-10356][network] add
sanity checks to SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#discussion_r234650118
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
##########
@@ -649,4 +713,23 @@ private static String randomString(Random random) {
return StringUtils.byteToHexString(bytes);
}
}
+
+ private static void throwDeserializationError(
+ int len,
+ int remainingBytes,
+ int leftOverDataStart,
+ int leftOverDataLimit,
+ @Nullable Throwable cause) throws IOException {
Review comment:
I still think, for this concrete code, this seems over-engineered, but well,
here you go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services