[
https://issues.apache.org/jira/browse/FLINK-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692670#comment-16692670
]
ASF GitHub Bot commented on FLINK-10940:
----------------------------------------
yanghua closed pull request #7145: [FLINK-10940] Refactor the maven
dependencies of Kafka 0.8 connector
URL: https://github.com/apache/flink/pull/7145
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-connectors/flink-connector-kafka-0.8/pom.xml
b/flink-connectors/flink-connector-kafka-0.8/pom.xml
index b3a65931869..e16321310c5 100644
--- a/flink-connectors/flink-connector-kafka-0.8/pom.xml
+++ b/flink-connectors/flink-connector-kafka-0.8/pom.xml
@@ -63,8 +63,10 @@ under the License.
<artifactId>flink-connector-kafka-base_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<exclusions>
- <!-- we need to exclude because the base module
has this but it doesn't exist
- for Kafka 0.8-->
+ <exclusion>
+ <groupId>org.apache.kafka</groupId>
+
<artifactId>kafka_${scala.binary.version}</artifactId>
+ </exclusion>
<exclusion>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
@@ -99,46 +101,8 @@ under the License.
<dependency>
<groupId>org.apache.kafka</groupId>
- <artifactId>kafka_${scala.binary.version}</artifactId>
+ <artifactId>kafka-clients</artifactId>
<version>${kafka.version}</version>
- <exclusions>
- <exclusion>
- <groupId>com.sun.jmx</groupId>
- <artifactId>jmxri</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.sun.jdmk</groupId>
- <artifactId>jmxtools</artifactId>
- </exclusion>
- <exclusion>
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-simple</artifactId>
- </exclusion>
- <exclusion>
- <groupId>net.sf.jopt-simple</groupId>
- <artifactId>jopt-simple</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-reflect</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-compiler</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.yammer.metrics</groupId>
-
<artifactId>metrics-annotation</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- </exclusion>
- </exclusions>
</dependency>
<!-- test dependencies -->
@@ -187,6 +151,20 @@ under the License.
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
+ <exclusions>
+ <!-- exclude Kafka dependencies -->
+ <exclusion>
+ <groupId>org.apache.kafka</groupId>
+
<artifactId>kafka_${scala.binary.version}</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka_${scala.binary.version}</artifactId>
+ <version>${kafka.version}</version>
+ <scope>test</scope>
</dependency>
<dependency>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor the maven dependencies of Kafka 0.8 connector
> ------------------------------------------------------
>
> Key: FLINK-10940
> URL: https://issues.apache.org/jira/browse/FLINK-10940
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> Currently, Kafka 0.9, 0.10, 0.11, the modern connector's dependent form
> remains uniform, but Kafka 0.8 is a special case. This issue will refactor
> it, and make it consistent with other versions of the connector.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
