[
https://issues.apache.org/jira/browse/FLINK-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706514#comment-14706514
]
ASF GitHub Bot commented on FLINK-2077:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-133364252
A few more comments from my side:
- The class overrides `equals()` but `hashCode()` has been removes. This
is a classical bug.
- The `compareTo()` method was a nice property (one could use Paths as
data types and keys). Would be nice to keep it.
- The main original problem was that the class did not support *mounted*
drives on Windows, as are common in environments with shared storage (Microsoft
Azure Cloud). I think these mounted drive paths start with `\\` or `//`.
> Rework Path class and add extend support for Windows paths
> ----------------------------------------------------------
>
> Key: FLINK-2077
> URL: https://issues.apache.org/jira/browse/FLINK-2077
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: GaoLun
> Priority: Minor
> Labels: starter
>
> The class {{org.apache.flink.core.fs.Path}} handles paths for Flink's
> {{FileInputFormat}} and {{FileOutputFormat}}. Over time, this class has
> become quite hard to read and modify.
> It would benefit from some cleaning and refactoring. Along with the
> refactoring, support for Windows paths like {{//host/dir1/dir2}} could be
> added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
