azagrebin opened a new pull request #7154: [FLINK-10946] Silent checkpoint async failures in task executor if job is not runnning URL: https://github.com/apache/flink/pull/7154 ## What is the purpose of the change When job is canceled, task closable registry is closed asynchronously and checkpoints cannot register with it any more from main thread. This leads to logging error message. The PR changes the behaviour and generates error only if job is still running, assuming that after cancelation checkpoint errors are not relevant any more. ## Brief change log - throw exception in AbstractStreamOperator.snapshotState only if job is still running. ## Verifying this change in loop (failure was flaky): cd flink-end-to-end-tests ./run-single-test.sh test-scripts/test_resume_externalized_checkpoints.sh 2 4 rocks true true ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
