StefanRRichter commented on a change in pull request #7154: [FLINK-10946]
Silent checkpoint async failures in task executor if job is not runnning
URL: https://github.com/apache/flink/pull/7154#discussion_r235645849
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -416,8 +416,10 @@ public final OperatorSnapshotFutures snapshotState(long
checkpointId, long times
String snapshotFailMessage = "Could not complete
snapshot " + checkpointId + " for operator " +
getOperatorName() + ".";
- LOG.info(snapshotFailMessage, snapshotException);
- throw new Exception(snapshotFailMessage,
snapshotException);
+ if (!getContainingTask().isCanceled()) {
+ LOG.info(snapshotFailMessage,
snapshotException);
+ throw new Exception(snapshotFailMessage,
snapshotException);
Review comment:
I think we should throw the exception in any case, so as to not return any
value here. That also matches the previous behaviour, only the logging was
added and needs to be guarded, the exception is already silenced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
