[
https://issues.apache.org/jira/browse/FLINK-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695724#comment-16695724
]
ASF GitHub Bot commented on FLINK-10942:
----------------------------------------
zhijiangW commented on issue #7146: [FLINK-10942][network,test] Deduplicate
common codes in OutputEmitterTest
URL: https://github.com/apache/flink/pull/7146#issuecomment-440970986
@pnowojski , thanks for helpful reviews!
I almost agree with all your above comments except the short loop way I
mentioned inline.
I already submit another hotfix for addressing all the issues, wish not
missing anything. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Deduplicate common codes in OutputEmitterTest
> ---------------------------------------------
>
> Key: FLINK-10942
> URL: https://issues.apache.org/jira/browse/FLINK-10942
> Project: Flink
> Issue Type: Sub-task
> Components: Network, Tests
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.7.1
>
>
> There are many duplicated codes in {{OutputEmitterTest}} to make it difficult
> to maintain. So it is necessary to abstract the common codes to make it
> simple which brings benefits for the following refactor work in
> {{ChannelSelector}} interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
