fhueske commented on a change in pull request #7147: [FLINK-10674] [table] Fix
handling of retractions after clean up
URL: https://github.com/apache/flink/pull/7147#discussion_r235723629
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
##########
@@ -95,6 +95,12 @@ class GroupAggProcessFunction(
var inputCnt = cntState.value()
if (null == accumulators) {
+ // don't create a new accumulator for unknown retractions
Review comment:
The retraction is not unknown, IMO.
I'd rephrase comment: "Don't create a new accumulator for a retraction
message. This might happen if the retraction message is the first message for
the key or after a state clean up."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
