xueyumusic commented on issue #7079: [FLINK-10845][table] Support multiple different DISTINCT aggregates for batch URL: https://github.com/apache/flink/pull/7079#issuecomment-441057747 hi, @twalthr , I tried simply by putting `FilterRemoveIsNotDistinctFromRule.INSTANCE` after `AggregateExpandDistinctAggregatesRule.JOIN` in `FlinkRuleSets`, it seems that does not work. I guess that [FilterRemoveIsNotDistinctFromRule](https://github.com/apache/calcite/blob/branch-1.17/core/src/main/java/org/apache/calcite/rel/rules/FilterRemoveIsNotDistinctFromRule.java#L62) finds IS_NOT_DISTINCT_FROM in the first rel filter, but [AggregateExpandDistinctAggregatesRule ](https://github.com/apache/calcite/blob/branch-1.17/core/src/main/java/org/apache/calcite/rel/rules/AggregateExpandDistinctAggregatesRule.java#L723)rewrites using IS_NOT_DISTINCT_FROM as multiple join condition.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
