StefanRRichter commented on a change in pull request #7153: FLINK-10918 Fix the 
checkpoint dir creation error on Window for keyed rocksdb state
URL: https://github.com/apache/flink/pull/7153#discussion_r235995638
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ##########
 @@ -557,6 +557,16 @@ private void createDB() throws IOException {
                this.defaultColumnFamily = columnFamilyHandles.get(0);
        }
 
+       private static class Utils {
+               static String getPathAsString(Path path) {
+                       String pathString = path.getPath();
 
 Review comment:
   I think a cleaner approach would by along the lines of `new 
File(path.toUri()).getAbsolutePath()`, the constructor should take care of 
transforming the URI to a system dependent string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to