pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r236174343
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala ########## @@ -1089,6 +1089,19 @@ abstract class TableEnvironment(val config: TableConfig) { } else { referenceByName(origName, t).map((_, name)) } + case (Key(UnresolvedFieldReference(name: String)), idx) => + if (isRefByPos) { Review comment: Please deduplicate this if and one if below, with non keyed versions. Either extract those if's to separate functions or convert whole match into a function sth like this: ``` foo(expr, index) { match expr { case Key(keyExpr) => foo(keyExpr, index) case UnresolvedFieldReference(...) => ... case Alias(UnresolvedFieldReference(...)) => ... } } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services