[ 
https://issues.apache.org/jira/browse/FLINK-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707178#comment-14707178
 ] 

ASF GitHub Bot commented on FLINK-2553:
---------------------------------------

Github user mbalassi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1037#discussion_r37661571
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount/StormWordCountRemoteBySubmitter.java
 ---
    @@ -71,7 +71,7 @@ public static void main(final String[] args) throws 
Exception {
                // conf.put(Config.NIMBUS_THRIFT_PORT, new Integer(6123));
     
                // The user jar file must be specified via JVM argument if 
executed via Java.
    -           // => 
-Dstorm.jar=target/flink-storm-examples-0.9-SNAPSHOT-WordCountStorm.jar
    +           // => 
-Dstorm.jar=target/flink-storm-examples-0.10-SNAPSHOT-WordCountStorm.jar
                // If bin/flink is used, the jar file is detected automatically.
    --- End diff --
    
    I would write 
`-Dstorm.jar=target/flink-storm-examples-*-WordCountStorm.jar` here and maybe 
also at the former location if that works. Easier to maintain. :)


> Example Jars not build correctly
> --------------------------------
>
>                 Key: FLINK-2553
>                 URL: https://issues.apache.org/jira/browse/FLINK-2553
>             Project: Flink
>          Issue Type: Bug
>          Components: flink-contrib
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Due to new examples that introduced some package restructuring, example jar 
> files are not build correctly. Furthermore, package/class structure got 
> messed up to some extend. Additionally, documentation need to be extended to 
> point out the correct example jar files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to