[ 
https://issues.apache.org/jira/browse/FLINK-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707505#comment-14707505
 ] 

ASF GitHub Bot commented on FLINK-2386:
---------------------------------------

Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1039#discussion_r37681201
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
 ---
    @@ -41,8 +41,7 @@ public void submitTopology(final String topologyName, 
final Map<?, ?> conf, fina
     
        public void submitTopologyWithOpts(final String topologyName, final 
Map<?, ?> conf, final FlinkTopology topology,
                        final SubmitOptions submitOpts) throws Exception {
    -           ClusterUtil
    -                           
.startOnMiniCluster(topology.getStreamGraph().getJobGraph(topologyName), 
topology.getNumberOfTasks());
    +           
ClusterUtil.startOnMiniCluster(topology.getStreamGraph().getJobGraph(topologyName),
 topology.getNumberOfTasks(), -1);
    --- End diff --
    
    Why is this changed? I think by default will also set it to -1


> Implement Kafka connector using the new Kafka Consumer API
> ----------------------------------------------------------
>
>                 Key: FLINK-2386
>                 URL: https://issues.apache.org/jira/browse/FLINK-2386
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> Once Kafka has released its new consumer API, we should provide a connector 
> for that version.
> The release will probably be called 0.9 or 0.8.3.
> The connector will be mostly compatible with Kafka 0.8.2.x, except for 
> committing offsets to the broker (the new connector expects a coordinator to 
> be available on Kafka). To work around that, we can provide a configuration 
> option to commit offsets to zookeeper (managed by flink code).
> For 0.9/0.8.3 it will be fully compatible.
> It will not be compatible with 0.8.1 because of mismatching Kafka messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to