zhijiangW commented on a change in pull request #7051: [FLINK-10820][network]
Simplify the RebalancePartitioner implementation
URL: https://github.com/apache/flink/pull/7051#discussion_r236286868
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/OutputEmitterTest.java
##########
@@ -211,26 +214,35 @@ public void testWrongKeyClass() throws Exception {
try {
delegate.setInstance(record);
- selector.selectChannels(delegate, 100);
+ selector.selectChannels(delegate);
} catch (DeserializationException re) {
return;
}
Assert.fail("Expected a NullKeyFieldException.");
}
+ private ChannelSelector createChannelSelector(
+ ShipStrategyType shipStrategyType,
+ TypeComparator comparator,
+ int numChannels) {
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
