[
https://issues.apache.org/jira/browse/FLINK-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699084#comment-16699084
]
ASF GitHub Bot commented on FLINK-8159:
---------------------------------------
dawidwys commented on a change in pull request #7110: [FLINK-8159] [cep]
Pattern(Flat)SelectFunctions should support RichFunction interface
URL: https://github.com/apache/flink/pull/7110#discussion_r236287295
##########
File path:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CepRuntimeContextTest.java
##########
@@ -0,0 +1,460 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cep;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.accumulators.Accumulator;
+import org.apache.flink.api.common.functions.AggregateFunction;
+import org.apache.flink.api.common.functions.BroadcastVariableInitializer;
+import org.apache.flink.api.common.functions.FoldFunction;
+import org.apache.flink.api.common.functions.ReduceFunction;
+import org.apache.flink.api.common.functions.RichFunction;
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.api.common.state.AggregatingStateDescriptor;
+import org.apache.flink.api.common.state.FoldingStateDescriptor;
+import org.apache.flink.api.common.state.ListStateDescriptor;
+import org.apache.flink.api.common.state.MapStateDescriptor;
+import org.apache.flink.api.common.state.ReducingStateDescriptor;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.cep.pattern.conditions.RichAndCondition;
+import org.apache.flink.cep.pattern.conditions.RichCompositeIterativeCondition;
+import org.apache.flink.cep.pattern.conditions.RichIterativeCondition;
+import org.apache.flink.cep.pattern.conditions.RichNotCondition;
+import org.apache.flink.cep.pattern.conditions.RichOrCondition;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.metrics.groups.UnregisteredMetricsGroup;
+import org.apache.flink.util.Collector;
+
+import org.junit.Test;
+
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test cases for {@link CepRuntimeContext}.
+ */
+public class CepRuntimeContextTest {
+
+ @Test
+ public void testRichPatternSelectFunction() throws Exception {
+ RichPatternSelectFunction<Integer, Integer> function = new
RichPatternSelectFunction<Integer, Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public Integer select(Map<String, List<Integer>>
pattern) throws Exception {
+ return null;
+ }
+ };
+
+ verifyRuntimeContext(function);
+ }
+
+ @Test
+ public void testRichPatternFlatSelectFunction() throws Exception {
+ RichPatternFlatSelectFunction<Integer, Integer> function =
+ new RichPatternFlatSelectFunction<Integer, Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public void flatSelect(Map<String,
List<Integer>> pattern, Collector<Integer> out) throws Exception {
+ // no op
+ }
+ };
+
+ verifyRuntimeContext(function);
+ }
+
+ @Test
+ public void testRichIterativeConditionFunction() throws Exception {
+ RichIterativeCondition<Integer> function = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ verifyRuntimeContext(function);
+ }
+
+ @Test
+ public void testRichCompositeIterativeCondition() throws Exception {
+ RichIterativeCondition<Integer> first = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichIterativeCondition<Integer> second = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichIterativeCondition<Integer> third = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichIterativeCondition<Integer> fourth = null;
+
+ RichCompositeIterativeCondition function = new
RichCompositeIterativeCondition(first, second, third, fourth) {
+ @Override
+ public boolean filter(Object value, Context ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ verifyRuntimeContext(function);
+ assertTrue(first.getRuntimeContext() instanceof
CepRuntimeContext);
+ assertTrue(second.getRuntimeContext() instanceof
CepRuntimeContext);
+ assertTrue(third.getRuntimeContext() instanceof
CepRuntimeContext);
+ }
+
+ @Test
+ public void testRichAndCondition() throws Exception {
+ RichIterativeCondition<Integer> left = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichIterativeCondition<Integer> right = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichAndCondition function = new RichAndCondition<>(left, right);
+
+ verifyRuntimeContext(function);
+ assertTrue(left.getRuntimeContext() instanceof
CepRuntimeContext);
+ assertTrue(right.getRuntimeContext() instanceof
CepRuntimeContext);
+ }
+
+ @Test
+ public void testRichOrCondition() throws Exception {
+ RichIterativeCondition<Integer> left = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichIterativeCondition<Integer> right = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichOrCondition function = new RichOrCondition<>(left, right);
+
+ verifyRuntimeContext(function);
+ assertTrue(left.getRuntimeContext() instanceof
CepRuntimeContext);
+ assertTrue(right.getRuntimeContext() instanceof
CepRuntimeContext);
+ }
+
+ @Test
+ public void testRichNotCondition() throws Exception {
+ RichIterativeCondition<Integer> original = new
RichIterativeCondition<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean filter(
+ Integer value, Context<Integer> ctx) throws
Exception {
+ return false;
+ }
+ };
+
+ RichNotCondition function = new RichNotCondition<>(original);
+
+ verifyRuntimeContext(function);
+ assertTrue(original.getRuntimeContext() instanceof
CepRuntimeContext);
+ }
+
+ private void verifyRuntimeContext(final RichFunction function) throws
Exception {
+ final String taskName = "foobarTask";
+ final MetricGroup metricGroup = new UnregisteredMetricsGroup();
+ final int numberOfParallelSubtasks = 42;
+ final int indexOfSubtask = 43;
+ final int attemptNumber = 1337;
+ final String taskNameWithSubtask = "barfoo";
+ final ExecutionConfig executionConfig =
mock(ExecutionConfig.class);
+ final ClassLoader userCodeClassLoader = mock(ClassLoader.class);
+
+ RuntimeContext mockedRuntimeContext =
mock(RuntimeContext.class);
+
+ when(mockedRuntimeContext.getTaskName()).thenReturn(taskName);
+
when(mockedRuntimeContext.getMetricGroup()).thenReturn(metricGroup);
+
when(mockedRuntimeContext.getNumberOfParallelSubtasks()).thenReturn(numberOfParallelSubtasks);
+
when(mockedRuntimeContext.getIndexOfThisSubtask()).thenReturn(indexOfSubtask);
+
when(mockedRuntimeContext.getAttemptNumber()).thenReturn(attemptNumber);
+
when(mockedRuntimeContext.getTaskNameWithSubtasks()).thenReturn(taskNameWithSubtask);
+
when(mockedRuntimeContext.getExecutionConfig()).thenReturn(executionConfig);
+
when(mockedRuntimeContext.getUserCodeClassLoader()).thenReturn(userCodeClassLoader);
+
+ function.setRuntimeContext(mockedRuntimeContext);
+
+ RuntimeContext runtimeContext = function.getRuntimeContext();
+
+ assertTrue(runtimeContext instanceof CepRuntimeContext);
+ assertEquals(taskName, runtimeContext.getTaskName());
+ assertEquals(metricGroup, runtimeContext.getMetricGroup());
+ assertEquals(numberOfParallelSubtasks,
runtimeContext.getNumberOfParallelSubtasks());
+ assertEquals(indexOfSubtask,
runtimeContext.getIndexOfThisSubtask());
+ assertEquals(attemptNumber, runtimeContext.getAttemptNumber());
+ assertEquals(taskNameWithSubtask,
runtimeContext.getTaskNameWithSubtasks());
+ assertEquals(executionConfig,
runtimeContext.getExecutionConfig());
+ assertEquals(userCodeClassLoader,
runtimeContext.getUserCodeClassLoader());
+
+ try {
+ runtimeContext.getDistributedCache();
+ fail("Expected getDistributedCached to fail with
unsupported operation exception.");
+ } catch (UnsupportedOperationException e) {
+ // expected
+ }
+
+ try {
+ runtimeContext.getState(new
ValueStateDescriptor<>("foobar", Integer.class, 42));
+ fail("Expected getState to fail with unsupported
operation exception.");
+ } catch (UnsupportedOperationException e) {
+ // expected
+ }
+
+ try {
+ runtimeContext.getListState(new
ListStateDescriptor<>("foobar", Integer.class));
+ fail("Expected getListState to fail with unsupported
operation exception.");
+ } catch (UnsupportedOperationException e) {
+ // expected
+ }
+
+ try {
+ runtimeContext.getReducingState(new
ReducingStateDescriptor<>("foobar", new ReduceFunction<Integer>() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public Integer reduce(Integer value1, Integer
value2) throws Exception {
+ return value1;
+ }
+ }, Integer.class));
+ fail("Expected getReducingState to fail with
unsupported operation exception.");
+ } catch (UnsupportedOperationException e) {
+ // expected
+ }
+
+ try {
+ runtimeContext.getAggregatingState(new
AggregatingStateDescriptor<>(
+ "foobar",
+ new AggregateFunction<Integer, Integer,
Integer>() {
Review comment:
How about mocks here? We do not care about the implementation...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Pattern(Flat)SelectFunctions should support RichFunction interface
> ------------------------------------------------------------------
>
> Key: FLINK-8159
> URL: https://issues.apache.org/jira/browse/FLINK-8159
> Project: Flink
> Issue Type: Sub-task
> Components: CEP
> Reporter: Dian Fu
> Assignee: Dian Fu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> {{SelectWrapper}} and {{FlatSelectWrapper}} should extends
> {{AbstractRichFucntion}} and process properly if the underlying functions
> extend RichFunction.
> Things to be very careful about:
> * backwards compatibility (we previously serialized conditions) - changes to
> those interfaces have to be done carefully
> * we want to be able to add dynamic patterns in the future, so at some point
> we have to open also on control message arrival
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
