[
https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699435#comment-16699435
]
ASF GitHub Bot commented on FLINK-10471:
----------------------------------------
azagrebin commented on a change in pull request #7163: [FLINK-10471][State TTL]
State TTL cleanup using RocksDb compaction filter
URL: https://github.com/apache/flink/pull/7163#discussion_r236381761
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -421,16 +427,29 @@ public void dispose() {
// invalidate the reference
db = null;
- IOUtils.closeQuietly(columnOptions);
IOUtils.closeQuietly(dbOptions);
IOUtils.closeQuietly(writeOptions);
+
+ for (RocksDbKvStateInfo kvStateInfo :
kvStateInformation.values()) {
+
IOUtils.closeQuietly(kvStateInfo.compactionFilter);
Review comment:
The closing order should be reverse to the order in which objects were
created. What do you mean by `missing ~`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> State TTL cleanup using RocksDb compaction filter
> -------------------------------------------------
>
> Key: FLINK-10471
> URL: https://issues.apache.org/jira/browse/FLINK-10471
> Project: Flink
> Issue Type: New Feature
> Components: State Backends, Checkpointing
> Affects Versions: 1.7.0
> Reporter: Andrey Zagrebin
> Assignee: Andrey Zagrebin
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
