[
https://issues.apache.org/jira/browse/FLINK-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700412#comment-16700412
]
ASF GitHub Bot commented on FLINK-11005:
----------------------------------------
tillrohrmann commented on a change in pull request #7176: [FLINK-11005] Define
flink-sql-client uber-jar dependencies via artifactSet
URL: https://github.com/apache/flink/pull/7176#discussion_r236660749
##########
File path: flink-libraries/flink-sql-client/pom.xml
##########
@@ -144,30 +144,19 @@ under the License.
<executions>
<!-- Exclude all flink-dist files and
only include flink-table and flink-sql-client -->
<execution>
+ <id>shade</id>
Review comment:
Yes, it should be `shade-flink`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Define flink-sql-client uber-jar dependencies via artifactSet
> -------------------------------------------------------------
>
> Key: FLINK-11005
> URL: https://issues.apache.org/jira/browse/FLINK-11005
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The module {{flink-sql-client}} defines the content of its uber jar via
> filtering files from the set of all dependencies. I think this is not ideal
> because it misses for example the {{NOTICE}} files from down stream
> dependencies.
> A solution could be to define an
> {{<artifactSet><includes><include></include></includes></artifactSet>}} and
> exclude files via the filter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
