pnowojski commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051#issuecomment-442358466 Personally I do not mind that much about separating PRs or creating separate Jira issues - but that's my personal opinion which other committers might not agree with and they might have a point. I’m personally fine with multiple commits in one PR, some of them might be “hotfixes” some of them “jira issues”, some of them may refer to the same jira issue. The important things for me are: 1. one commit does one thing 2. the smaller commits the easier to review 3. renames/refactorings that do not change semantics/add new features ALWAYS in separate commit 4. if you do multiple independent refactorings/renames, each on of them should be in separate commit 5. two following up commits shouldn’t modify the same code (unless one is pure refactor like deduplicating the code and another is adding feature/bug fixing). This speeds up reviewing and later reading the code by browsing git history “why something was done in a way it was done” - extreme example: finding 1 line bug fix hidden within 1000 lines of renames/refactoring is not easy. While on the other hand, having a small commit with good commit message explaining why something was implemented often helps a lot if you go through git annotations in IDE.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
