[
https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701662#comment-16701662
]
ASF GitHub Bot commented on FLINK-11015:
----------------------------------------
twalthr commented on a change in pull request #7182: [FLINK-11015] Remove
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237019737
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkBase.java
##########
@@ -57,12 +55,11 @@
protected final Properties properties;
/** Serialization schema for encoding records to Kafka. */
- protected Optional<SerializationSchema<Row>> serializationSchema;
+ protected final Optional<SerializationSchema<Row>> serializationSchema;
/** Partitioner to select Kafka partition for each item. */
protected final Optional<FlinkKafkaPartitioner<Row>> partitioner;
- // legacy variables
protected String[] fieldNames;
Review comment:
I think we also don't need these variables anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove deprecated methods and classes about table from all the Kafka
> connectors
> -------------------------------------------------------------------------------
>
> Key: FLINK-11015
> URL: https://issues.apache.org/jira/browse/FLINK-11015
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> This is to make the "Disentangle flink-connector-kafka from flink-table and
> flink-json" (FLINK-9461) plan more smoothly. For more details, please refer
> to the discussion of FLINK-9461.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
