yanghua commented on a change in pull request #7182: [FLINK-11015] Remove 
deprecated methods and classes about table from all the Kafka connectors
URL: https://github.com/apache/flink/pull/7182#discussion_r237055489
 
 

 ##########
 File path: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkBase.java
 ##########
 @@ -57,12 +55,11 @@
        protected final Properties properties;
 
        /** Serialization schema for encoding records to Kafka. */
-       protected Optional<SerializationSchema<Row>> serializationSchema;
+       protected final Optional<SerializationSchema<Row>> serializationSchema;
 
        /** Partitioner to select Kafka partition for each item. */
        protected final Optional<FlinkKafkaPartitioner<Row>> partitioner;
 
-       // legacy variables
        protected String[] fieldNames;
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to