kl0u commented on a change in pull request #7161: [FLINK-10963][fs-connector,
s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.
URL: https://github.com/apache/flink/pull/7161#discussion_r237062852
##########
File path:
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/RecoverableMultiPartUploadImpl.java
##########
@@ -209,6 +204,10 @@ static String incompleteObjectNamePrefix(String
objectName) {
return parent + (child.isEmpty() ? "" : '_') + child + "_tmp_";
}
+ private String createIncompletePartObjectName() {
+ return namePrefixForTempObjects + UUID.randomUUID().toString();
Review comment:
This `UUID` was added in an effort to add entropy to the paths/objects
uploaded to S3. I agree that any randomness, makes cleaning up more difficult
but I think this discussion fits better to the JIRA that will handle the
general cleaning up of left-over temporary files/objects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
