[ 
https://issues.apache.org/jira/browse/FLINK-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708391#comment-14708391
 ] 

ASF GitHub Bot commented on FLINK-2563:
---------------------------------------

GitHub user vasia opened a pull request:

    https://github.com/apache/flink/pull/1042

    [FLINK-2563] [gelly] changed Graph's run() to return an arbitrary result 
type

    Added a type parameter to the 'GraphAlgorithm' interface to allow 
implementing library methods that return single values, Graphs of different 
types, etc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vasia/flink graphAlgorithm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1042
    
----
commit ff7240b9fd1a899c938108604875ea16023e7a78
Author: vasia <[email protected]>
Date:   2015-08-23T11:06:15Z

    [FLINK-2563] [gelly] extended the run() method of GraphAlgorithm interface 
to return an arbitrary type

----


> Gelly's Graph Algorithm Interface is limited
> --------------------------------------------
>
>                 Key: FLINK-2563
>                 URL: https://issues.apache.org/jira/browse/FLINK-2563
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 0.9, 0.10
>            Reporter: Andra Lungu
>            Assignee: Vasia Kalavri
>
> Right now, Gelly's `GraphAlgorithm` interface only allows users/devs to 
> return the same type of Graph.
> public Graph<K, VV, EV> run(Graph<K, VV, EV> input) throws Exception;
> In numerous cases, one needs to return a single value, or a modified graph. 
> Off the top of my head, say one would like to implement a Triangle Count 
> library method. That takes as input a Graph and returns the total number of 
> triangles. 
> https://github.com/andralungu/gelly-partitioning/blob/master/src/main/java/example/GSATriangleCount.java
> With the current Gelly abstractions, something like this cannot be supported. 
> Also if I initially had a Graph of Long, Long, NullValue and my algorithm 
> changed the edge values to type Double, for instance, I would again have 
> created an implementation which is not supported. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to