[
https://issues.apache.org/jira/browse/FLINK-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702892#comment-16702892
]
ASF GitHub Bot commented on FLINK-10597:
----------------------------------------
twalthr commented on a change in pull request #7189: [FLINK-10597][table]
Enabled UDFs support in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7189#discussion_r237396997
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##########
@@ -131,47 +132,39 @@ class MatchCodeGenerator(
: GeneratedFunction[F, T] = {
val funcName = newName(name)
val collectorTypeTerm = classOf[Collector[Any]].getCanonicalName
- val (functionClass, signature, inputStatements, isInterface) =
- if (clazz == classOf[IterativeCondition[_]]) {
- val baseClass = classOf[IterativeCondition[_]]
+ val (functionClass, signature, inputStatements) =
+ if (clazz == classOf[IterativeCondition[_]] || clazz ==
classOf[RichIterativeCondition[_]]) {
Review comment:
Is there a reason to support both interface and rich class? I would keep it
simple here and only support the rich variant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable UDFs support in MATCH_RECOGNIZE
> --------------------------------------
>
> Key: FLINK-10597
> URL: https://issues.apache.org/jira/browse/FLINK-10597
> Project: Flink
> Issue Type: Sub-task
> Components: CEP, Table API & SQL
> Reporter: Dawid Wysakowicz
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
