dianfu commented on a change in pull request #7189: [FLINK-10597][table] 
Enabled UDFs support in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7189#discussion_r237464451
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
 ##########
 @@ -131,47 +132,39 @@ class MatchCodeGenerator(
     : GeneratedFunction[F, T] = {
 
 Review comment:
   We can add something like `reusablePrepareInputStatements` in CodeGenerator 
and  place it before `reuseInputUnboxingCode` when generating the function. 
Then we can make use of `reusablePrepareInputStatements` to construct the 
`reusePatternLists`. But I'm fine with the current implementation as 
`reusablePrepareInputStatements` is currently only useful for CEP. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to