GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1045

    [FLINK-2557] TypeExtractor properly returns MissingTypeInfo

    This fix is not really obvious so let me explain:
    
    getParameterTye() is called from two different places in the TypeExtractor; 
to validate the input type and to extract the output type.
    
    Both cases consider the possibility that getParameterType() fails, but 
check for different exceptions. 
    
    The TypeExtractor only returns a MissingTypeInfo if it encounters an 
InvalidTypesException; IllegalArgumentExceptions are not catched. This is what 
@mjsax encountered.
    Changing the exception type causes the TypeExtractor to properly return a 
MissingTypeInfo, which is later overridden by the returns(...) call.
    
    In order for the input validation to still work properly aswell, it now 
catches InvalidTypesExceptions instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 2557_types

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1045.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1045
    
----
commit 1c1dc459915c875ab0a4412aa3ef0a844f092171
Author: zentol <s.mo...@web.de>
Date:   2015-08-23T19:41:44Z

    [FLINK-2557] TypeExtractor properly returns MissingTypeInfo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to