azagrebin commented on issue #6777: [FLINK-10461] [State Backends, Checkpointing] Speed up download files when restore from DFS URL: https://github.com/apache/flink/pull/6777#issuecomment-443148880 Thanks for addressing the comment. One more thing, I think we do not actually need the `running` flag because we register streams in closable registry. In case of canceling the job, the runnables will either fail to register streams or will be interrupted because streams will be closed unexpectedly and break the while loop anyways with IO exception which is what we want. The while loops will not hold executor shutdown for long. Sorry for confusion. Can we still change it and remove the atomic `running`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
