[
https://issues.apache.org/jira/browse/FLINK-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704490#comment-16704490
]
ASF GitHub Bot commented on FLINK-10461:
----------------------------------------
azagrebin commented on issue #6777: [FLINK-10461] [State Backends,
Checkpointing] Speed up download files when restore from DFS
URL: https://github.com/apache/flink/pull/6777#issuecomment-443148880
Thanks for addressing the comment.
One more thing, I think we do not actually need the `running` flag because
we register streams in closable registry. In case of canceling the job, the
runnables will either fail to register streams or will be interrupted because
streams will be closed unexpectedly and break the while loop anyways with IO
exception which is what we want. The while loops will not hold executor
shutdown for long. Sorry for confusion.
Can we still change it and remove the atomic `running`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Speed up download file procedure when restore
> ----------------------------------------------
>
> Key: FLINK-10461
> URL: https://issues.apache.org/jira/browse/FLINK-10461
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Reporter: Congxian Qiu
> Assignee: Congxian Qiu
> Priority: Major
> Labels: pull-request-available
>
> In the current master branch, the restore will download file from DFS, the
> download procedure are single-thread, this could speed up by using
> multi-thread for downloading states from DFS.
>
> In my company, the states will come to some terabytes, so the restore
> procedure will become a litter slow, after a bit digging, I find download
> states from DFS using single thread, this could using multi-thread for speed
> up.
> I test the time used for download states from DFS with ~2 terabytes states.
> With single thread it used 640+s, and 130+s when using 5 threads for download.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
