dawidwys commented on a change in pull request #7168: [FLINK-6756][DataStream API] Provide Rich AsyncFunction to Scala API … URL: https://github.com/apache/flink/pull/7168#discussion_r237784773
########## File path: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/util/ScalaRichAsyncFunctionWrapper.scala ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.scala.async.util + +import org.apache.flink.api.common.functions.RuntimeContext +import org.apache.flink.configuration.Configuration +import org.apache.flink.streaming.api.functions.async.{ResultFuture, RichAsyncFunction => JRichAsyncFunction} +import org.apache.flink.streaming.api.scala.async.{JavaResultFutureWrapper, RichAsyncFunction} + +/** + * A wrapper function that exposes a Scala RichAsyncFunction as a Java Rich Async Function. + * + * The Scala and Java RichAsyncFunctions differ in their type of "ResultFuture" + * - Scala RichAsyncFunction: org.apache.flink.streaming.api.scala.async.ResultFuture + * - Java RichAsyncFunction: org.apache.flink.streaming.api.functions.async.ResultFuture + */ +final class ScalaRichAsyncFunctionWrapper[IN, OUT](func: RichAsyncFunction[IN, OUT]) + extends JRichAsyncFunction[IN, OUT]{ + + override def asyncInvoke(input: IN, resultFuture: ResultFuture[OUT]): Unit = { + func.asyncInvoke(input, new JavaResultFutureWrapper[OUT](resultFuture)) + } + + override def timeout(input: IN, resultFuture: ResultFuture[OUT]): Unit = { + func.timeout(input, new JavaResultFutureWrapper[OUT](resultFuture)) + } + + override def open(parameters: Configuration): Unit = { + super.open(parameters) + func.open(parameters) + } + + override def close(): Unit = { + super.close() Review comment: Same as above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
