[
https://issues.apache.org/jira/browse/FLINK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706800#comment-16706800
]
ASF GitHub Bot commented on FLINK-7208:
---------------------------------------
walterddr commented on issue #7201: [FLINK-7208] [table] Optimize
Min/MaxWithRetractAggFunction with DataView
URL: https://github.com/apache/flink/pull/7201#issuecomment-443621920
Hmm. Somehow the test did not catch the problem. My point was: the dataview
type should be handled by the `AggregateUtils` class via the following
[code](https://github.com/apache/flink/blob/master/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala#L1454-L1471).
I have to double check but somehow my feeling is that it doesn't seem like
it is using the state backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor build-in agg(MaxWithRetractAccumulator and
> MinWithRetractAccumulator) using the DataView
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-7208
> URL: https://issues.apache.org/jira/browse/FLINK-7208
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: kaibo.zhou
> Assignee: Dian Fu
> Priority: Major
> Labels: pull-request-available
>
> Refactor build-in agg(MaxWithRetractAccumulator and
> MinWithRetractAccumulator) using the DataView.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
