[
https://issues.apache.org/jira/browse/FLINK-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706934#comment-16706934
]
ASF GitHub Bot commented on FLINK-11011:
----------------------------------------
azagrebin opened a new pull request #7216: [FLINK-11011][E2E][JM] Log error
messages about null CheckpointCoordinator only if job is running
URL: https://github.com/apache/flink/pull/7216
## What is the purpose of the change
When Job master gets checkpoint acknowledge or decline message and
CheckpointCoordinator is null, it is an error unless job is not running any
more. If job is being stopped, it can happen that CheckpointCoordinator has
been already closed and null'ed but Job master keeps getting pending checkpoint
messages from task executors which do not matter any more.
## Brief change log
Check `JobStatus.RUNNING` in `JobMaster.acknowledgeCheckpoint` and
`JobMaster. declineCheckpoint` before outputting `CheckpointCoordinator ==
null` error
## Verifying this change
Looped originally failed e2e test CI build:
https://travis-ci.org/azagrebin/flink/builds/461783136
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Elasticsearch 6 sink end-to-end test unstable
> ---------------------------------------------
>
> Key: FLINK-11011
> URL: https://issues.apache.org/jira/browse/FLINK-11011
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.8.0, 1.7.1
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Critical
> Labels: pull-request-available
>
> The log contains errors:
> {code}
> 2018-11-26 12:55:02,363 ERROR org.apache.flink.runtime.jobmaster.JobMaster -
> Received DeclineCheckpoint message for job 1a7516a04fb0cc85bdb3aa21548bd9bb
> with no CheckpointCoordinator
> {code}
>
> See also: https://api.travis-ci.org/v3/job/459693461/log.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
