[
https://issues.apache.org/jira/browse/FLINK-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709037#comment-14709037
]
ASF GitHub Bot commented on FLINK-2564:
---------------------------------------
GitHub user ChengXiangLi opened a pull request:
https://github.com/apache/flink/pull/1047
[FLINK-2564] Failing Test: RandomSamplerTest
As discussed in
[here](https://github.com/apache/flink/pull/949#issuecomment-133990256), it's a
balance between accurate verification and failure-positive result. As this
failure and KS test failure happens more often than expected, we should expand
the verification boundary which would reduce the fail-positive case to an
acceptable level.
With this PR, the KS test and fraction verification never fail after tens
of thousands executions in my local environment. @tillrohrmann , @chiwanpark .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChengXiangLi/flink FLINK-2564
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit ab5c81d708c31591df160b323244df7fe4445dc6
Author: chengxiang li <[email protected]>
Date: 2015-08-24T09:49:44Z
[FLINK-2564] [test] expand the verification boundary for random sampler
test.
----
> Failing Test: RandomSamplerTest
> -------------------------------
>
> Key: FLINK-2564
> URL: https://issues.apache.org/jira/browse/FLINK-2564
> Project: Flink
> Issue Type: Bug
> Reporter: Matthias J. Sax
> Assignee: Chengxiang Li
> Labels: test-stability
>
> {noformat}
> Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.943 sec
> <<< FAILURE! - in org.apache.flink.api.java.sampling.
> testPoissonSamplerFraction(org.apache.flink.api.java.sampling.RandomSamplerTest)
> Time elapsed: 0.017 sec <<< FAILURE!
> java.lang.AssertionError: expected fraction: 0.010000, result fraction:
> 0.011300
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.flink.api.java.sampling.RandomSamplerTest.verifySamplerFraction(RandomSamplerTest.java:249)
> at
> org.apache.flink.api.java.sampling.RandomSamplerTest.testPoissonSamplerFraction(RandomSamplerTest.java:116)
> Results :
> Failed tests:
> Successfully installed excon-0.33.0
> RandomSamplerTest.testPoissonSamplerFraction:116->verifySamplerFraction:249
> expected fraction: 0.010000, result fraction: 0.011300
> {noformat}
> Full log: https://travis-ci.org/apache/flink/jobs/76720572
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
