[ 
https://issues.apache.org/jira/browse/FLINK-10887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707342#comment-16707342
 ] 

ASF GitHub Bot commented on FLINK-10887:
----------------------------------------

jgrier edited a comment on issue #7099: [FLINK-10887] [jobmaster] Add source 
watermark tracking to the JobMaster
URL: https://github.com/apache/flink/pull/7099#issuecomment-443739811
 
 
   Sorry I haven't responded to this.  We had a baby boy this week so that has 
kept me pretty busy ;)
   
   Okay, so I'm on board with generifying this further.  @StephanEwen if we're 
to do a generic transient aggregator do you mean to allow the client to provide 
the aggregation function?  In this case the API would look something like this:
   
   ```
   /**
    * Update the aggregate and return the new value.
    *
    * @param aggregateName The name of the aggregate to update
    * @param aggregand The value to add to the aggregate
    * @param aggregationFunction The function to apply to the current aggregate 
and aggregand to obtain the new aggregate value
    * @return The updated aggregate
   CompletableFuture<Object> updateAggregate(
         String aggregateName,
         Object aggregand,
         AggregateFunction aggregationFunction);
   ```
   
   Is something like this what you had in mind?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add source watermark tracking to the JobMaster
> ----------------------------------------------
>
>                 Key: FLINK-10887
>                 URL: https://issues.apache.org/jira/browse/FLINK-10887
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager
>            Reporter: Jamie Grier
>            Assignee: Jamie Grier
>            Priority: Major
>              Labels: pull-request-available
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> We need to add a new RPC to the JobMaster such that the current watermark for 
> every source sub-task can be reported and the current global minimum/maximum 
> watermark can be retrieved so that each source can adjust their partition 
> read rates in an attempt to keep sources roughly aligned in event time.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to