[ 
https://issues.apache.org/jira/browse/FLINK-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707406#comment-16707406
 ] 

ASF GitHub Bot commented on FLINK-10842:
----------------------------------------

tillrohrmann commented on issue #7221: [FLINK-10842][E2E tests] fix broken 
waiting loops in common.sh
URL: https://github.com/apache/flink/pull/7221#issuecomment-443758049
 
 
   Thanks for the contribution @azagrebin. Merging this PR since the local 
Travis run is green.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Waiting loops are broken in e2e/common.sh
> -----------------------------------------
>
>                 Key: FLINK-10842
>                 URL: https://issues.apache.org/jira/browse/FLINK-10842
>             Project: Flink
>          Issue Type: Bug
>          Components: E2E Tests
>    Affects Versions: 1.7.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> There are 3 loops in flink-end-to-end-tests/test-scripts/common.sh where the 
> script waits for some event to happen (for i in \{1..10}; do):
>  - wait_dispatcher_running
>  - start_and_wait_for_tm
>  - wait_job_running
> All loops have 10 iterations and the loop breaks if the awaited event 
> happens. If timeout occurs then the script does not fail and the function 
> just continues after 10 iterations ignoring that the awaited event did not 
> happen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to