[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709113#comment-14709113 ]
ASF GitHub Bot commented on FLINK-2525: --------------------------------------- Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r37741748 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java --- @@ -41,8 +43,49 @@ public void submitTopology(final String topologyName, final Map<?, ?> conf, fina public void submitTopologyWithOpts(final String topologyName, final Map<?, ?> conf, final FlinkTopology topology, final SubmitOptions submitOpts) throws Exception { - ClusterUtil - .startOnMiniCluster(topology.getStreamGraph().getJobGraph(topologyName), topology.getNumberOfTasks()); + JobGraph jobGraph = topology.getStreamGraph().getJobGraph(topologyName); + Configuration jobConfiguration = jobGraph.getJobConfiguration(); + + /* storm conf type must be Map<String, Object> */ + Map<String, Object> stormConf = (Map<String, Object>)conf; --- End diff -- The configuration in Strom is an untyped `Map`. Casting it to `Map<String, Object>` might fail. Flink should not limit the Map in this way. > Add configuration support in Storm-compatibility > ------------------------------------------------ > > Key: FLINK-2525 > URL: https://issues.apache.org/jira/browse/FLINK-2525 > Project: Flink > Issue Type: New Feature > Components: flink-contrib > Reporter: fangfengbin > Assignee: fangfengbin > > Spouts and Bolt are initialized by a call to `Spout.open(...)` and > `Bolt.prepare()`, respectively. Both methods have a config `Map` as first > parameter. This map is currently not populated. Thus, Spouts and Bolts cannot > be configure with user defined parameters. In order to support this feature, > spout and bolt wrapper classes need to be extended to create a proper `Map` > object. Furthermore, the clients need to be extended to take a `Map`, > translate it into a Flink `Configuration` that is forwarded to the wrappers > for proper initialization of the map. -- This message was sent by Atlassian JIRA (v6.3.4#6332)