Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37741748
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
---
@@ -41,8 +43,49 @@ public void submitTopology(final String topologyName,
final Map<?, ?> conf, fina
public void submitTopologyWithOpts(final String topologyName, final
Map<?, ?> conf, final FlinkTopology topology,
final SubmitOptions submitOpts) throws Exception {
- ClusterUtil
-
.startOnMiniCluster(topology.getStreamGraph().getJobGraph(topologyName),
topology.getNumberOfTasks());
+ JobGraph jobGraph =
topology.getStreamGraph().getJobGraph(topologyName);
+ Configuration jobConfiguration = jobGraph.getJobConfiguration();
+
+ /* storm conf type must be Map<String, Object> */
+ Map<String, Object> stormConf = (Map<String, Object>)conf;
--- End diff --
The configuration in Strom is an untyped `Map`. Casting it to `Map<String,
Object>` might fail. Flink should not limit the Map in this way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
