[
https://issues.apache.org/jira/browse/FLINK-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709419#comment-16709419
]
ASF GitHub Bot commented on FLINK-10543:
----------------------------------------
sunjincheng121 commented on a change in pull request #6918:
[FLINK-10543][table] Leverage efficient timer deletion in relational operators
URL: https://github.com/apache/flink/pull/6918#discussion_r238884712
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/CleanupState.scala
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.aggregate
+
+import org.apache.flink.api.common.state.ValueState
+import org.apache.flink.streaming.api.functions.ProcessFunction
+import org.apache.flink.streaming.api.functions.co.CoProcessFunction
+import java.lang.{Long => JLong}
+
+import org.apache.flink.streaming.api.TimerService
+
+/**
+ * Base class for clean up state, both for [[ProcessFunction]] and
[[CoProcessFunction]].
+ */
+trait CleanupState {
+
+ def registerProcessingCleanupTimer(
+ stateCleaningEnabled: Boolean,
+ cleanupTimeState: ValueState[JLong],
+ currentTime: Long,
+ minRetentionTime: Long,
+ maxRetentionTime: Long,
+ timerService: TimerService): Unit = {
+
+ if (stateCleaningEnabled) {
+
+ // last registered timer
+ val curCleanupTime = cleanupTimeState.value()
+
+ // check if a cleanup timer is registered and
+ // that the current cleanup timer won't delete state we need to keep
+ if (curCleanupTime == null || (currentTime + minRetentionTime) >
curCleanupTime) {
+ // we need to register a new (later) timer
+ val cleanupTime = currentTime + maxRetentionTime
+ // register timer and remember clean-up time
+ timerService.registerProcessingTimeTimer(cleanupTime)
+ // delete expired timer
+ if (curCleanupTime != null) {
+ timerService.deleteProcessingTimeTimer(curCleanupTime)
+ }
+ cleanupTimeState.update(cleanupTime)
+ }
+ }
+ }
+
+ def needToCleanupState(
+ stateCleaningEnabled: Boolean,
+ cleanupTimeState: ValueState[JLong],
+ timestamp: Long): Boolean = {
+
+ if (stateCleaningEnabled) {
+ val cleanupTime = cleanupTimeState.value()
+ // check that the triggered timer is the last registered processing time
timer.
+ null != cleanupTime && timestamp == cleanupTime
+ } else {
+ false
+ }
+ }
+}
Review comment:
Add `cleanupState(states: State*)`, so we can remove both
`CoProcessFunctionWithCleanupState` and `ProcessFunctionWithCleanupState`.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Leverage efficient timer deletion in relational operators
> ---------------------------------------------------------
>
> Key: FLINK-10543
> URL: https://issues.apache.org/jira/browse/FLINK-10543
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Hequn Cheng
> Priority: Minor
> Labels: pull-request-available
>
> FLINK-9423 added support for efficient timer deletions. This feature is
> available since Flink 1.6 and should be used by the relational operator of
> SQL and Table API.
> Currently, we use a few workarounds to handle situations when deleting timers
> would be the better solution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
