sunjincheng121 commented on a change in pull request #6918:
[FLINK-10543][table] Leverage efficient timer deletion in relational operators
URL: https://github.com/apache/flink/pull/6918#discussion_r238885237
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala
##########
@@ -169,17 +167,9 @@ class ProcTimeBoundedRangeOver(
function.retract(accumulators, retractRow)
iRemove += 1
}
- // mark element for later removal not to modify the iterator over
MapState
- markToRemove.add(elementKey)
+ iter.remove()
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
