[
https://issues.apache.org/jira/browse/FLINK-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710823#comment-16710823
]
ASF GitHub Bot commented on FLINK-10974:
----------------------------------------
sunjincheng121 commented on a change in pull request #7196: [FLINK-10974]
[table] Add support for flatMap to table API
URL: https://github.com/apache/flink/pull/7196#discussion_r239273278
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala
##########
@@ -320,6 +320,18 @@ case class TableFunctionCall(
override private[flink] def children: Seq[Expression] = parameters
+ def as(fields: Symbol*): TableFunctionCall = {
+ this.aliases = Some(fields.map(_.name))
+ this
+ }
+
+ def as(fields: String): TableFunctionCall = {
+ val fieldExprs = ExpressionParser
Review comment:
For Robustness I suggest add empty check, something like `if(fields.isEmpty)
return this`, What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add FlatMap to TableAPI
> -----------------------
>
> Key: FLINK-10974
> URL: https://issues.apache.org/jira/browse/FLINK-10974
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: Dian Fu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> Add FlatMap operator to Table API as described in [Google
> doc|https://docs.google.com/document/d/1tnpxg31EQz2-MEzSotwFzqatsB4rNLz0I-l_vPa5H4Q/edit#heading=h.q23rny2iglsr].
> The usageļ¼
> {code:java}
> val res = tab
> .flatMap(fun: TableFunction) // output has columns 'a, 'b, 'c
> .select('a, 'c)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
