[
https://issues.apache.org/jira/browse/FLINK-11075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711213#comment-16711213
]
ASF GitHub Bot commented on FLINK-11075:
----------------------------------------
igalshilman commented on issue #7243: [FLINK-11075] [core] Remove irrelevant
code in CompatibilityUtil#resolveCompatibilityResult
URL: https://github.com/apache/flink/pull/7243#issuecomment-444814531
LGTM 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove redundant code path in CompatibilityUtil
> -----------------------------------------------
>
> Key: FLINK-11075
> URL: https://issues.apache.org/jira/browse/FLINK-11075
> Project: Flink
> Issue Type: Improvement
> Components: Type Serialization System
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> In {{CompatibilityUtil#resolveCompatibilityResult}}:
> {code:java}
> CompatibilityResult<T> initialResult = resolveCompatibilityResult(
> (TypeSerializerSnapshot<T>) precedingSerializerConfigSnapshot,
> newSerializer);
> if (!initialResult.isRequiresMigration()) {
> return initialResult;
> } else {
> if (precedingSerializer != null &&
> !(precedingSerializer.getClass().equals(dummySerializerClassTag))) {
> // if the preceding serializer exists and is not a dummy, use
> // that for converting instead of any provided convert deserializer
> return CompatibilityResult.requiresMigration((TypeSerializer<T>)
> precedingSerializer);
> } else {
> // requires migration (may or may not have a convert deserializer)
> return initialResult;
> }
> {code}
> {{initialResult}} can actually be returned already, since the case where we
> try to provide a convert deserializer is no longer relevant. We do not need
> to check if a convert deserializer is provided because that will never be the
> case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
